FEVER for ReAct #39
Merged
FEVER for ReAct #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alckasoc
added
enhancement
alckasoc
requested changes
Feb 20, 2024
alckasoc
requested changes
Feb 20, 2024
alckasoc
requested changes
Feb 21, 2024
alckasoc
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Looks solid so far. I think eventually when we get close to merging this PR, we can remove the alfworld environment and the user can define that. It's important to make sure the ReActAgent has access to the necessary prompts for alfworld. The environment can be user defined. Otherwise, awesome!
alckasoc
requested changes
Feb 24, 2024
There was a problem hiding this comment.
Overall, it looks pretty good! Just some syntax improvements + some questions + some pytest stuff. Take a look at the comments I left. Also, double check over the code to make sure everything is properly documented, linted, and tested (and, importantly, everything is organized well)!
alckasoc
previously approved these changes
Mar 29, 2024
|
Alfworld removed -> library is unstable
|
alckasoc
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Reasoning
🚧 Changes
Mostly copied the orginal ReAct Agent
Change the _prompt_agent by adding a new parameter benchmark_types
Adding new example
Improvement :
✅ PR Checklist